Optuna resume study #2647
Open
Optuna resume study #2647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
Could somebody help me understand the errors? I am not sure how to fix my code in order to have it pass the tests. |
|
There's an annoying issue that hasn't been fixed yet in master that's adding noise to the tests. Can you include the fix from #2731 in your PR, which hopefully will clean up the CI logs? |
|
Thanks, it doesn't seem to help though. |
|
Hmm, yeah there are a bunch of errors that seem unlikely to have anything to do with your PR. I'm afraid CI is currently broken. |
|
Okay, thanks for confirming. I'll hope someone will review and accept this anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When using the Optuna sweeper and the
storageoption, theoptuna.studywill actually be resumed (ref).However, the sweeper will reset the
job_idxto 0 and then_trials_to_goto the number originally configured (i.e., before interrupting the sweep).It's confusing that the reloading is done but the configured job parameters are not updated. This PR makes it explicit by allowing the configuration of the
load_if_existsparameter. IfTrue(by default - for strongest backwards compatibility) the study is loaded if it already exists. Then_trials_to_goandjob_idxare then updated accordingly. IfFalse, an Optuna error will be raised. Note this parameter acts exactly in accordance with optuna.Have you read the Contributing Guidelines on pull requests?
Yes, but it's my first contribution so any feedback is welcome.
Test Plan
I added an additional test to demonstrate and test the desired behavior.
Related Issues and PRs
This is related to #1407 and should close #1679. (W.r.t. #1679 the garbage collecting can be done in a callback, I can optionally demonstrate in that issue before it's closed).